PT TN: money, measure, telephone, electronic#416
Open
folivoramanh wants to merge 2 commits intoNVIDIA:staging/pt-br_tnfrom
Open
PT TN: money, measure, telephone, electronic#416folivoramanh wants to merge 2 commits intoNVIDIA:staging/pt-br_tnfrom
folivoramanh wants to merge 2 commits intoNVIDIA:staging/pt-br_tnfrom
Conversation
Adds semiotic classes and tests on top of staging/pt-br_tn; includes cardinal fix for X00 + 01–09 and Sparrowhawk script updates. Signed-off-by: Mai Anh <palasek182@gmail.com>
folivoramanh
force-pushed
the
pt_tn_measure_money_telephone_electronic
branch
from
42445af to
7b8ee51
Compare
for more information, see https://pre-commit.ci
mgrafu
reviewed
Apr 22, 2026
| https://www.nvidia.com~h t t p s dois pontos barra barra w w w ponto nvidia ponto com | ||
| http://site.com.br~h t t p dois pontos barra barra s i t e ponto com ponto br | ||
| nvidia.com~nvidia ponto com | ||
| @usuario~arroba u s u a r i o No newline at end of file |
Collaborator
There was a problem hiding this comment.
let's have a tsv file where we distinguish company names or common terms that should not be space-separated in this normalization (so they will behave like your l5 and l7) and let's include google and usuario in that file as well as some common companies. let's add different examples for char-separated and keep these as staying together
mgrafu
reviewed
Apr 22, 2026
| preserve_order = pynutil.insert(" preserve_order: true") | ||
|
|
||
| integer_plus_maj = pynini.union( | ||
| graph_integer + insert_space + pynutil.insert(curr_symbol) @ graph_maj_plural, |
Collaborator
There was a problem hiding this comment.
should we have the space with the currency symbols be optional to allow both normalizations?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds semiotic classes and tests on top of staging/pt-br_tn; includes cardinal fix for X00 + 01–09 and Sparrowhawk script updates.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.